Attempted fix for crash with runtime generics#2309
Closed
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Closed
Attempted fix for crash with runtime generics#2309ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
Member
|
Yes, this makes the error go away (but I'm not sure how :-). |
Current coverage is 83.17% (diff: 0.00%)@@ master #2309 diff @@
==========================================
Files 72 72
Lines 19047 19052 +5
Methods 0 0
Messages 0 0
Branches 3920 3922 +2
==========================================
Hits 15847 15847
- Misses 2605 2608 +3
- Partials 595 597 +2
|
gvanrossum
reviewed
Oct 25, 2016
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Maybe a better check would be to check whether it's a Callable before casting?
Also the hasattr() looks a bit desperate. :-)
Member
|
Closing in favor of #2333. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.